Support starttls connections #1084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide ability to serve "starttls_options", if set ssl will be disabled.
jeremy
requested changes
May 16, 2017
|
|
||
| imap = Net::IMAP.new(settings[:address], settings[:port], settings[:enable_ssl], nil, false) | ||
| tmp_ssl = settings[:enable_ssl] | ||
| tmp_ssl = false unless settings[:starttls_options].nil? |
There was a problem hiding this comment.
Since these options are mutually exclusive, we can raise an ArgumentError if both are set.
| tmp_ssl = false unless settings[:starttls_options].nil? | ||
|
|
||
| imap = Net::IMAP.new(settings[:address], settings[:port], tmp_ssl, nil, false) | ||
| if settings[:starttls_options].is_a?(Hash) |
There was a problem hiding this comment.
Providing an options hash to enable/disable the feature is a bit awkward, particular if you don't need to set any options. Would expose this as a boolean: starttls: true
|
|
||
| imap = Net::IMAP.new(settings[:address], settings[:port], tmp_ssl, nil, false) | ||
| if settings[:starttls_options].is_a?(Hash) | ||
| imap.starttls(settings[:starttls_options]) |
There was a problem hiding this comment.
These options aren't unique to STARTTLS. They're also used when SSL is enabled. Both establish a TLS session on the socket.
That suggests calling this tls_options: { … } and allowing it to be used in conjunction with both IMAPS and STARTTLS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide ability to serve "starttls_options", if set ssl will be disabled.