Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse unquoted names with commas in it #1365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Svelix
Copy link

@Svelix Svelix commented Nov 12, 2019

Fixes #1219

@scmyers11
Copy link

Is there any progress on this or a good workaround? We have production users being affected by this in the from the sendgrid-griddler gem.

@mattwalters
Copy link

We also have production users being affected by this.

Is there any intention of merging this? If there is some outstanding problem, I'd be willing to contribute effort toward a solution.

@mikel
Copy link
Owner

mikel commented Dec 3, 2022

Hi there @Svelix, thank you for this!

I'm doing a bunch of mail stuff at the moment, just pushed 2.8 out the door with some urgent fixes, but I'm happy to include this in 2.9 which I'll probably release next week or the week after. Could you please rebase this onto the latest master and I'll get it merged once all the specs pass.

cc @scmyers11 and @mattwalters thank you for your

@mikel mikel added this to the 2.9.0 milestone Dec 3, 2022
@mattwalters
Copy link

Thank you @Svelix and @mikel 🚀

@Svelix
Copy link
Author

Svelix commented Dec 5, 2022

@mikel Did the rebase, but now the tests are failing. I currently don't have much time to look into it thoroughly, maybe I can take care about it later in two or three weeks, but I cannot promise it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mail::Address.new parsing failed when string has a comma
4 participants