Add former default gems as a dependency for Ruby 3.1 compatibility #1439

casperisfine · 2021-05-28T07:24:59Z

It was recently removed from the default gems:

…ruby-head build They were recently removed from Ruby's default gems. Ref: https://bugs.ruby-lang.org/issues/17873 Ref: mikel/mail#1439 Ref: teamcapybara/capybara#2468

casperisfine · 2021-05-28T10:02:41Z

Actually this cause double loading warnings for ruby 3.0 and older. I'm not too sure yet how best to fix this.

casperisfine · 2021-05-29T08:03:45Z

David Rodríguez, bundler's maintainer is looking at the issue, I'll keep an eye and report back here when there's a solution: https://bugs.ruby-lang.org/issues/17873#note-18

casperisfine · 2021-07-07T08:33:24Z

So the double loading issue was fixed in rubygems/bundler, we can probably merge this now.

Ref: mikel/mail#1439

net-smtp has been removed from default gems in Ruby 3.1, but it is used by the `mail` gem. Remove when mikel/mail#1439 is fixed

See the following: * rails/rails#42366 * mikel/mail#1439 * https://bugs.ruby-lang.org/issues/17873 In essence, the net/smtp gem config was changed in ruby 3.1 and the mail gem needs to merge in their fix.

casperisfine · 2021-10-12T11:08:30Z

Any news here?

jeremy · 2021-10-18T15:22:11Z

mail.gemspec

@@ -14,6 +14,9 @@ Gem::Specification.new do |s|
  s.rdoc_options << '--exclude' << 'lib/mail/values/unicode_tables.dat'

  s.add_dependency('mini_mime', '>= 0.1.1')
+  s.add_dependency('net-smtp')
+  s.add_dependency('net-imap')
+  s.add_dependency('net-pop')


Do these gems no-op on older Rubies (1.8, 1.9, etc)?

These gems yes, however they themselves have digest as dependency which is causing some doable loading problem:

/Users/byroot/.gem/ruby/2.7.2/gems/digest-3.0.0/lib/digest.rb:6: warning: already initialized constant Digest::REQUIRE_MUTEX /opt/rubies/2.7.2/lib/ruby/2.7.0/digest.rb:6: warning: previous definition of REQUIRE_MUTEX was here ....

I already submitted the fix in bundler rubygems/rubygems#4989, hopefully it should be fixed soon. I totally understand if you want to wait for bundler to fix this first.

I think this is already fixed @jeremy @casperisfine. Can we release this?

Would it make sense to wrap these in an if statement that is only true for Ruby 3.1+?

The problem here is those gems can't be installed on older versions, @casperisfine's reply only shows part of the issue.

For example on 2.0.0:

$ gem i net-smtp Fetching: timeout-0.2.0.gem (100%) Successfully installed timeout-0.2.0 Fetching: io-wait-0.2.1.gem (100%) ERROR: Error installing net-smtp: io-wait requires Ruby version >= 2.6.0. $ gem i net-imap ERROR: Error installing net-imap: io-wait requires Ruby version >= 2.6.0. $ gem i net-pop ERROR: Error installing net-pop: io-wait requires Ruby version >= 2.6.0.

Also #1439 (comment)

@nertzy I am pretty sure that an if statement in a .gemspec ends up getting evaluated at gem release time, and trying to condition on ruby version would end up being on what ruby version is running in the environment doing the gem release, and then fixed in the release.

My understanding is you can't actually do dynamic conditions based on the running environment in a gemspec like that.

Ideally those gems ('net-smtp', 'net-imap' and 'net-pop') would all NOOP when installed on an older unsupported Ruby. That would just solve it for everyone.

So I'm still trying to find solutions upstream, but ultimately would you be open to drop pre 2.5 support to get this moved forward now?

For context, CRuby devs don't seem generally happy to need to explicitly support (even as noop) such old and EOL Ruby versions based on recent discussions, which brings the age-old question: do gems depending on net-* and specifically mail still need to support Ruby <= 2.5 today?

We can still go this way as well.

#1439 (comment)

Bump minor (or major) version and we can still maintain releases compat with <= 2.5 if needed in "legacy" branch.

Btw. I'm happy to help with anything moving this forward.

lewispb · 2021-11-11T10:18:49Z

Could we merge master and add Ruby 3.1 to the GitHub Actions matrix?

It was recently removed from the default gems: - https://bugs.ruby-lang.org/issues/17873 - ruby/ruby#4530

casperisfine · 2021-11-12T09:28:55Z

Hum:

net-imap was resolved to 0.2.2, which depends on
        Ruby (>= 2.5.0)

That's a problem, not sure how we can possibly handle this.

eregon · 2021-11-12T10:45:37Z

If they noop (#1439 (comment)), maybe the required_ruby_version should be lower?

casperisfine · 2021-11-12T10:47:37Z

If they noop

What do you mean?

casperisfine · 2021-11-12T11:06:29Z

Ah nevermind, seems like I didn't properly understand @jeremy's question. They definitely don't noop.

So I don't see how we can support both 3.1 and 2.4

eregon · 2021-11-12T11:11:37Z

A somewhat crazy idea:
Create a new gem, e.g., mail-deps and make two releases:

one release with required_ruby_version < 3.1, and no deps
one release with required_ruby_version >= 3.1, and those 3 deps

Alternatively maybe those 3 gems should really have "empty/noop/using stdlib" releases with required_ruby_version < 2.5, so there is no need to redo something similar manually on top.

Ref: mikel/mail#1439 Some gems depend on io-wait, but still support older rubies, so they have to chose between droping support or not listing io-wait. But io-wait could act a a noop on older rubies.

Ref: mikel/mail#1439 Some gems depend on io-wait, but still support older rubies, so they have to chose between droping support or not listing io-wait. But io-wait could act a a noop on older rubies. ruby/io-wait@75fcb74c32

deivid-rodriguez · 2022-02-16T18:14:41Z

I think @simi's suggestion at #1439 (comment) is the best way to go. In order to reduce maintainers' burden to implement that solution, I created #1472, including the changes being proposed here.

deivid-rodriguez · 2022-02-16T18:24:23Z

My PR includes a lot of cleanups of old Ruby 1.8 compatibility code that can be now removed. It can be argued that reviewing those changes actually increases maintainers' burden 😅. If that's the case, I'm super happy to remove those cleanups from my PR.

Necessary until mikel/mail#1439 got merged.

Make use of parallel and matrix builds. Note Ruby v3.1 is not yet supported due to a breakage of `mail` gem due to a missing `net-smtp` dependency: mikel/mail#1439 (comment)

See mikel/mail#1439

We need to do this as the `mail` gem hasn't yet been updated. See mikel/mail#1439.

- Bump PORTREVISION for dependency change This commit also reverts da6b780. Reference: mikel/mail#1439

Necessary until mikel/mail#1439 got merged.

mikel · 2022-04-19T05:36:06Z

Closing this in favour of #1472

see mikel/mail#1439

When moving to Ruby 3.1 some parts of the standard library were moved to default gems[0][1]. While we're on Rails 6.x they need to be included in the gem file, as discussed in this this GitHub issue[2]. Once we upgrade to Rails 7 these requirments can be dropped. [0] https://bugs.ruby-lang.org/issues/17873 [1] https://stdgems.org/#default-gems-ruby-301 [2] mikel/mail#1439 (comment)

example: $ bundle exec rake test ... snip ... /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:30: warning: method redefined; discarding old protocol_param /Users/alexdean/.rvm/gems/ruby-2.6.4/gems/net-protocol-0.2.1/lib/net/protocol.rb:32: warning: previous definition of protocol_param was here /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:38: warning: method redefined; discarding old ssl_socket_connect /Users/alexdean/.rvm/gems/ruby-2.6.4/gems/net-protocol-0.2.1/lib/net/protocol.rb:40: warning: previous definition of ssl_socket_connect was here /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:66: warning: already initialized constant Net::ProtocRetryError /Users/alexdean/.rvm/gems/ruby-2.6.4/gems/net-protocol-0.2.1/lib/net/protocol.rb:68: warning: previous definition of ProtocRetryError was here /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:79: warning: method redefined; discarding old initialize /Users/alexdean/.rvm/gems/ruby-2.6.4/gems/net-protocol-0.2.1/lib/net/protocol.rb:81: warning: previous definition of initialize was here /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:82: warning: method redefined; discarding old io /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:84: warning: method redefined; discarding old message changes made so far don't seem to resolve the error, so this might not be useful. unsure, but it seems like these might be due to bug in mail and/or rubygems. mikel/mail#1439

Necessary until mikel/mail#1439 got merged.

Alpine 3.17 comes with ruby-3.1, which runs into some compattibility issues for certain gems. So this includes some patches to make sure it's compattible: 1. openssl is pinned to 3.0.1, the versions shipped with ruby 3.1[0] 2. net-smtp, net-imap and net-pop gems are added as they are no longer bundled[1] 3. psych is kept on a version <4 as version 4 is backwards incompattible[2]. [0]:https://gitlab.com/gitlab-org/gitlab/-/blob/v15.10.0-ee/Gemfile#L22 [1]:mikel/mail#1439 [2]:https://bugs.ruby-lang.org/issues/1786

casperisfine mentioned this pull request May 28, 2021

Add net-smtp and matrix to the Gemfile to fix the ruby-head build rails/rails#42308

Merged

casperisfine changed the title ~~Add net-smtp as a dependency for Ruby 3.1 compatibility~~ Add former default gems as a dependency for Ruby 3.1 compatibility May 28, 2021

yahonda mentioned this pull request Jun 3, 2021

Add net/smtp gem for bug report templates to support Ruby 3.1 rails/rails#42366

Merged

tagliala added a commit to enriclluelles/route_translator that referenced this pull request Sep 12, 2021

Add net-smtp gem explicitly

90f47b3

Ref: mikel/mail#1439

tagliala mentioned this pull request Sep 12, 2021

Add net-smtp gem explicitly enriclluelles/route_translator#248

Merged

tagliala added a commit to enriclluelles/route_translator that referenced this pull request Sep 12, 2021

Add net-smtp gem explicitly

f873559

net-smtp has been removed from default gems in Ruby 3.1, but it is used by the `mail` gem. Remove when mikel/mail#1439 is fixed

dillonwelch mentioned this pull request Oct 11, 2021

Add fix to ruby-head issue devise-security/devise-security#328

Merged

jeremy reviewed Oct 18, 2021

View reviewed changes

simi approved these changes Oct 24, 2021

View reviewed changes

lewispb mentioned this pull request Nov 9, 2021

Ruby 3.1 compatibility #1461

Closed

byroot added 2 commits November 11, 2021 15:23

Add net-smtp as a dependency for Ruby 3.1 compatibility

9f80a1e

It was recently removed from the default gems: - https://bugs.ruby-lang.org/issues/17873 - ruby/ruby#4530

Also add net-imap and net-pop to the gemspec

651a59a

casperisfine force-pushed the net-smtp-dependency branch from 58704be to 651a59a Compare November 11, 2021 14:23

tvdeyen added a commit to tvdeyen/alchemy_cms that referenced this pull request Feb 18, 2022

Install net-smtp if using Ruby 3.1

817eb58

Necessary until mikel/mail#1439 got merged.

hsbt mentioned this pull request Feb 19, 2022

Cannot Load net/smtp rubygems/rubygems#5367

Closed

itsmechlark added a commit to carabao-capital/devise-auth0 that referenced this pull request Feb 28, 2022

Fixes mikel/mail#1439

6f5c965

itsmechlark added a commit to carabao-capital/devise-auth0 that referenced this pull request Feb 28, 2022

Fixes mikel/mail#1439

3842b19

petergoldstein mentioned this pull request Mar 4, 2022

Add Ruby 3.1 and Rails 6.1 and 7 to the CI matrix Shopify/job-iteration#194

Merged

hank-spokeo added a commit to hank-spokeo/apipie-rails that referenced this pull request Mar 15, 2022

fix for LoadError: cannot load such file -- net/smtp

e0fb98a

See mikel/mail#1439

ethax-ross added a commit to DFE-Digital/schools-experience that referenced this pull request Mar 24, 2022

Pull in net-smtp manually

ac32103

We need to do this as the `mail` gem hasn't yet been updated. See mikel/mail#1439.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Mar 25, 2022

mail/rubygem-mail: Add dependencies for Ruby 3.1+

a250faf

- Bump PORTREVISION for dependency change This commit also reverts da6b780. Reference: mikel/mail#1439

ocochard pushed a commit to ocochard/freebsd-ports that referenced this pull request Mar 28, 2022

mail/rubygem-mail: Add dependencies for Ruby 3.1+

9d20a59

- Bump PORTREVISION for dependency change This commit also reverts da6b780. Reference: mikel/mail#1439

tvdeyen added a commit to tvdeyen/alchemy_cms that referenced this pull request Apr 11, 2022

Install net-smtp if using Ruby 3.1

6cb2098

Necessary until mikel/mail#1439 got merged.

mikel closed this Apr 19, 2022

jrochkind mentioned this pull request May 5, 2022

Convert range limit views + helpers to presenters + components projectblacklight/blacklight_range_limit#179

Merged

espen added a commit to espen/rails-letsencrypt that referenced this pull request Jul 13, 2022

net-smtp is no longer part of Ruby default gems

96bed9b

see mikel/mail#1439

peteryates mentioned this pull request Jul 20, 2022

Attempted deployment fix by requiring default gems DFE-Digital/npq-registration#471

Merged

javierjulio referenced this pull request in fphilipe/premailer-rails Nov 11, 2022

Add net-smtp for Ruby 3

5b2aa73

mikel mentioned this pull request Nov 30, 2022

Add Ruby 3.1 support to Mail 2.7 branch #1482

Closed

alexdean mentioned this pull request Jan 4, 2023

WIP: try to address warnings about constant redefinitions alexdean/as2#21

Closed

dbwinger pushed a commit to dbwinger/alchemy_cms that referenced this pull request Mar 20, 2023

Install net-smtp if using Ruby 3.1

554fabb

Necessary until mikel/mail#1439 got merged.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add former default gems as a dependency for Ruby 3.1 compatibility #1439

Add former default gems as a dependency for Ruby 3.1 compatibility #1439

casperisfine commented May 28, 2021

casperisfine commented May 28, 2021

casperisfine commented May 29, 2021

casperisfine commented Jul 7, 2021

casperisfine commented Oct 12, 2021

jeremy Oct 18, 2021

casperisfine Oct 18, 2021

simi Dec 26, 2021

nertzy Jan 4, 2022

eregon Jan 4, 2022 •

edited

Loading

jrochkind Jan 4, 2022

mikel Feb 2, 2022

casperisfine Feb 2, 2022

eregon Feb 2, 2022 •

edited

Loading

simi Feb 2, 2022 •

edited

Loading

lewispb commented Nov 11, 2021

casperisfine commented Nov 12, 2021

eregon commented Nov 12, 2021

casperisfine commented Nov 12, 2021

casperisfine commented Nov 12, 2021

eregon commented Nov 12, 2021 •

edited

Loading

deivid-rodriguez commented Feb 16, 2022

deivid-rodriguez commented Feb 16, 2022

mikel commented Apr 19, 2022

Add former default gems as a dependency for Ruby 3.1 compatibility #1439

Add former default gems as a dependency for Ruby 3.1 compatibility #1439

Conversation

casperisfine commented May 28, 2021

casperisfine commented May 28, 2021

casperisfine commented May 29, 2021

casperisfine commented Jul 7, 2021

casperisfine commented Oct 12, 2021

jeremy Oct 18, 2021

Choose a reason for hiding this comment

casperisfine Oct 18, 2021

Choose a reason for hiding this comment

simi Dec 26, 2021

Choose a reason for hiding this comment

nertzy Jan 4, 2022

Choose a reason for hiding this comment

eregon Jan 4, 2022 • edited Loading

Choose a reason for hiding this comment

jrochkind Jan 4, 2022

Choose a reason for hiding this comment

mikel Feb 2, 2022

Choose a reason for hiding this comment

casperisfine Feb 2, 2022

Choose a reason for hiding this comment

eregon Feb 2, 2022 • edited Loading

Choose a reason for hiding this comment

simi Feb 2, 2022 • edited Loading

Choose a reason for hiding this comment

lewispb commented Nov 11, 2021

casperisfine commented Nov 12, 2021

eregon commented Nov 12, 2021

casperisfine commented Nov 12, 2021

casperisfine commented Nov 12, 2021

eregon commented Nov 12, 2021 • edited Loading

deivid-rodriguez commented Feb 16, 2022

deivid-rodriguez commented Feb 16, 2022

mikel commented Apr 19, 2022

eregon Jan 4, 2022 •

edited

Loading

eregon Feb 2, 2022 •

edited

Loading

simi Feb 2, 2022 •

edited

Loading

eregon commented Nov 12, 2021 •

edited

Loading