Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMTP: allow disabling starttls_auto since it's now true by default in Ruby 3 #1480

Merged
merged 1 commit into from
Nov 30, 2022
Merged

SMTP: allow disabling starttls_auto since it's now true by default in Ruby 3 #1480

merged 1 commit into from
Nov 30, 2022

Commits on Apr 29, 2022

  1. SMTP: allow disabling starttls_auto since it's now true by default in… 

    … Ruby 3

Passing enable_tls/starttls/starttls_auto: false now explicitly disables
these options. They used to be all false by default, so they could only
be turned ON. So we ignored turning them OFF!

We now disable_tls/starttls/starttls_auto when they're set to false.
Leaving them set to nil inherits the upstream default.
    @jeremy @ahorek
    jeremy authored and ahorek committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    8ede2ac View commit details
    Browse the repository at this point in the history