Fixed charset warning issue with multipart messages #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an add_file was called to add an attachment on a plain (non-multipart) message, the call which was made to create a new "Part" did not copy over the charset of the earlier plain-text message, but instead copied over only the body. Later, it would always show a warning message that the charset had to be detected, even though it was set before. Caveat: You need to set charset before the first call to add_file.
mikel
added a commit
that referenced
this pull request
Apr 26, 2011
Fixed charset warning issue with multipart messages
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added a test for this, got it failing and fixed it.
This issue was discussed by you here as well: http://groups.google.com/group/mail-ruby/browse_thread/thread/27c3bf043087dcda?pli=1
When an add_file was called to add an attachment on a plain (non-multipart) message with UTF-8 characters, the call which was made to create a new "Part" did not copy over the charset of the earlier plain-text message, but instead copied over only the body. Later, it would always show a warning message that the charset had to be detected, even if it was set before.
Caveat: You need to set charset before the first call to add_file.
Thanks,
Arvind