-
Notifications
You must be signed in to change notification settings - Fork 205
Email notification #22
Comments
Great idea and I have thought about adding email notifications, it is defiantly on the todo list. |
How can I help?Jesse On Apr 13, 2012, at 7:56 AM, mikelbring wrote:
|
Let's talk about that. Can you send me an email? me [at] michaelhasselbring.com |
Looking into the code it looks as if a simple first version could be connected to the 'activity' code. When ever an activity is created for your user an Email is sent out, with a small yes/no option in the user preferences. |
I have a different idea for this. I think at the bottom of the issue page there is a list of all the user's in the project with a checkbox next to each one that receives a notification of an update in this issue. If you post a comment, your name automatically gets checked. I think basecamp does something like this, thoughts? |
So, would this be something you could turn off or on for each post? For example, I comment on an issue and there are three other people on the project, I could select that only one of them gets the new comment? I was thinking I could open an issue and somewhere I could check "Notify me when things change" or some such. And I could turn that on or off for any issue. Then when anybody makes a change, I would get notified. On any new issue for a project I am assigned to, I would be notified. Maybe that too would be a checkbox on the project... Two different approaches. Either would work. I would prefer to be in control of what messages I receive than let the one making the comment.Jesse On Apr 15, 2012, at 8:03 PM, mikelbring wrote:
|
This feature is paramount. Something like the project author mentioned that subscribes additional users who comment on issues akin to Basecamp would be neat. By default it should probably notify the managers (if they have it enabled in their user settings) and the person who the issue is assigned to. I've hacked basic notifications into my system, I'll try to refactor to match your code base when I have time, it's super cheesy and a horrible code wise in all sorts of ways at the moment. I hope this feature gets added sooner rather than later, even a basic implementation at first would be nice. |
@North2Alaska Allowing someone else notify you lets them make you aware of the issue, if it needs to then be in your court. It's just an option. I am going to give it more thought, been really busy but planning to put together a new release soon. |
These are all good ideas, my suggestion was just a quick fix that could be implemented in a night to get the ball rolling. I has a quick go myself but my PHP skills have falling off a cliff. |
I'm keen to start using TinyProject for actual bug tracking with our real clients, but need to get the email notification stuff resolved first. Basic implementation: Everyone who has interacted with the ticket will get notified of any additional activity (comments, status changes etc). Looks like we can use the activity table for this and pipe it into an email? even basic plaintext formatting will suffice for now. Future ideas to refine this feature: Allow checkboxes for optional notification, muting of conversations, add replies as comments, digest emails, etc If we agree to focus on the basic implementation for now and then once that's setup we'll have a base to add the additional functionality. I'm happy to help get this moving in the right direction. Now does laravel have a decent Email / SMTP library? :D |
Just to let everyone know that I've done some work on the basic implementation of this feature on this branch https://github.com/deplorableword/tinyissue/tree/feature-email For new issues, everyone on the project will be notified of a new issue. For follow up activity (status change, comments etc) only users who have interacted with the issue will get notified. I've only setup the initial comment notification email template so far, contributions are most welcome, especially around finishing up the additional templates. @North2Alaska I agree that users need control of notification (stop watching, notifying additional users etc) so interested in how we could hook this up and make it simple. @TheBiggerGuy If you'd like to contribute some small changes, there are email templates in views/email/activity which need hooking up :) @nhodges would be interested in seeing where you ended up and how this differs to mine? @mikelbring I'll fire over a pull request when this basic implementation ready for testing |
I like what I see. I think you are spot on with everyone assigned to the project gets notified when a new item gets entered. The person assigned (unless you assign it to yourself, no need to send a message then) should get a different notification. Now you just need some way to turn it off (or on if I just want to watch the action). As far as additional notifications, what if we were to add a "Notify" column to projects_issues. This column could be a simple list of user_ids in a comma separated list. When an issue get created all participants in the project get added to the list. When I interact with an issue (create one or add a comment etc...), my id gets added to the Notify list. When I view any issue, there would be a check box "Follow" or sum such. If my id is in the list, it is checked, if not then not. If I check it, I'm added to the list. When a "change" happens to an issue, everyone in the Notify list gets an email, EXCEPT if I am the one making the event happen, don't send me an email. On May 22, 2012, at 1:00 PM, Tom Martin wrote:
|
Ah yep good call about the person that initiates the action should get a different notification. Also need to think about the messages that are sent when a user assigns a issue from one to another. In terms of following / unfollowing issues, think we should create another model to handle it instead of using the projects_issue table. Think it'll be much more flexible in the long term, if say a user wants to follow notifications for an issue they have involvement with or we want to generate a list of all users following an issue. I'll continue working out the notification stuff and then we can work out how to handle following / unfollowing later. In the longer term, I want to extend the email system to support sending email via Postmark, specifically so we can handle incoming email / replies |
I've done a bit more work on this today, I've added all of the activity types email templates. If you grab https://github.com/deplorableword/tinyissue/tree/b2c5162c8e7f53907facfd9830a3f1ecef4d9504 you can give it a spin. Here's a list of things I see that need to be done to get the email notification shipped.
If anyone wants to do any the above, feel free! Just let us know on this issue so we don't duplicate efforts :) |
i'm trying notification mail, work fine, but a bug when update a project after create this. 'undefined variable activity' |
@spham Yep still was a WIP I think, pull requests to my fork/branch are most welcome :) |
@deplorableword : i don't know how to make a request with github. it's seems hidden function... |
https://github.com/deplorableword/tinyissue/tree/feature-email
can't create pull request on your git |
Alternatively, it would be good to have RSS feeds generated for projects activity. Is it worth filing another issue for this (is it desirable/useful)? |
Yup, would be useful to have RSS and useful to have it as a separate issue On 28 March 2013 16:42, nodiscc notifications@github.com wrote:
|
What is the current status of the email feature? Is there anybody who is working on this feature? |
I don't believe so. I want to focus on an API for the next big update, that will open doors for plugins and outside applications. |
Do you have an estimated completion date for the API or any information about it? |
Great work so far! +1 on Email notifications. Email notifications on a par with what Redmine does is a deal maker/breaker I think. |
+1 |
Using your code, works really great! |
This is a duplicate of what's already done in pull request #161. |
guys i was trying to get some kind of whole project group notifications going but really couldn't see a way to do so in the existing code without learning laravel and waiting for the new version etc etc meantime my people needed to know stuff was happening project-wide so i created a hideously ugly hack that works and doesn't touch the existing codebase, other than to add a column in a table, adds 1 php script (plus a convenience class for db stuff), and needs a cronjob it might be completely useless for everybody but me but i would like to post it somewhere in case it helps anybody at all, but i'm not sure it's good as a merge (not sure how to do that yet in GIT anyways) so can someone suggest an alternative method for me to get these files up? thanks |
@fake-fur Hey, the best way is probably to create a gist https://gist.github.com/ with the instructions and the files you modified, then paste the URL as a comment here. Like you say, might be useful to someone. In terms of the actual-email-notification-feature. I honestly haven't worked on this for at least two years, hoping someone finds the time to finish it off. |
hey again - thanks for the heads up - learn something new every day :) the gist url is: https://gist.github.com/fake-fur/2ffba0aa0c55a160b95d hope it helps someone |
I would like to have an option to receive email notification when an issue, assigned to me or one that I have "Subscribed" to, changes.
The text was updated successfully, but these errors were encountered: