-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and reorganization #54
Merged
mikelolasagasti
merged 10 commits into
mikelolasagasti:master
from
gpoo:cleanup-and-reorganization
Sep 27, 2020
Merged
Cleanup and reorganization #54
mikelolasagasti
merged 10 commits into
mikelolasagasti:master
from
gpoo:cleanup-and-reorganization
Sep 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make parameters consistent when using portable functions to build a path.
No need to have many levels of directories for a few files.
No need to have many levels of directories for a few files.
As we have one UI file in a gresource, it is better to have them all.
Avoid distributing a single file in ui given that the UI files are integrated into a gresource file.
mikelolasagasti
requested changes
Sep 26, 2020
* Use limit of 80 columns. The idea is to make it easy to read either on a web browser, text editor, or terminal * Remove HTML, use markdown formatting for image.
There are two README files. One is only required because of autotools. Later we can migrate to meson, and the warning will be gone. README.md already accomplish the same function.
gpoo
force-pushed
the
cleanup-and-reorganization
branch
from
September 26, 2020 12:14
f6f90bb
to
cb76a4e
Compare
Merged
mikelolasagasti
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of patches that clean unused code, as well as reorganization
in the data directory, which ends up reducing the directories and
Makefile.am
files to process. Also, there is renaming of files to make them consistent with
the rest of files.
I have another branch to work on top of this (or whatever changes were needed)
to use meson as a built system.