Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33 #35

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Fixes #33 #35

merged 3 commits into from
Jun 7, 2018

Conversation

jpoles1
Copy link
Contributor

@jpoles1 jpoles1 commented Jun 6, 2018

In my first commit, I add node-sass as a dev dependency, and while not technically necessary, use it to build the project js and css files.

In the second commit I have made the modifications to fix the possibly non-unicode "x" character for closing the box. This was displaying incorrectly as shown in issue #33 . I had to edit the css in order to make the "x" render in the right place on desktop. I have not been able to check that this works on mobile as of yet.

May make a demo page for this repo for testing purposes which can help the user (and editor) see what it looks like. I guess this would be a page with settings to consider all browsers "out of date".

@jpoles1
Copy link
Contributor Author

jpoles1 commented Jun 6, 2018

Very simple demo page can be seen here. Seems that this fix works on my mobile device.

@mikemaccana
Copy link
Owner

  • I love the demo page idea by setting everything to false
  • Ah I understand, the 'multiply x' vs the 'letter x'. I do think the old multiply one looks better but the point is this should work everywhere so you're right let's change the character.
  • I'll merge all of these - they're cool - but really they should be separate PRs - 'Use better x character' 'Support npm build' 'Add a demo page' etc. Just makes history easier to read!

@mikemaccana mikemaccana merged commit ece7930 into mikemaccana:master Jun 7, 2018
@jpoles1
Copy link
Contributor Author

jpoles1 commented Jun 7, 2018

Got it, will work to separate out my PRs in the future. Recommend enabling ghpages for this repo, and adding a link to the README if you weren't already going to.

@jpoles1 jpoles1 mentioned this pull request Jun 7, 2018
@mikemaccana
Copy link
Owner

Done!

https://mikemaccana.github.io/outdated-browser-rework/

Also linked to from README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants