Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update angular-acl.js #26

Merged
merged 1 commit into from Feb 9, 2017
Merged

Update angular-acl.js #26

merged 1 commit into from Feb 9, 2017

Conversation

tavoli
Copy link
Contributor

@tavoli tavoli commented Feb 9, 2017

method to drop data acl from web storage

method to drop data acl from web storage
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.8%) to 53.913% when pulling bd6524d on gustavojnt:master into 21ed26d on mikemclin:master.

@mikemclin
Copy link
Owner

Is there a reason while you chose the method drop? I didn't know if this was common nomenclature for removing a persisted state (like session/cache) in a different package, etc. To me, it seems more like a flush?

@tavoli
Copy link
Contributor Author

tavoli commented Feb 9, 2017

The method name can be flush. Thanks for the remark!

@mikemclin
Copy link
Owner

mikemclin commented Feb 9, 2017

Thanks for the contribution. I'll tag it in this evening.

@mikemclin mikemclin merged commit ca3b80f into mikemclin:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants