Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with NG_HIDE_CLASS variable in aclShow directive. #28

Merged
merged 3 commits into from
Mar 1, 2017

Conversation

sindhushaballa
Copy link
Contributor

Hi,

Please merge this request if you are fine with the changes.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b06c726 on bsurendrakumar:0.1.8-fix into ** on mikemclin:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a0f1cd2 on bsurendrakumar:0.1.8-fix into ** on mikemclin:master**.

@mikemclin mikemclin merged commit 60473b7 into mikemclin:master Mar 1, 2017
@mikemclin
Copy link
Owner

Actually, this issue is that I placed the NG_HIDE_CLASS inside of the provider function, so it wasn't available to the directive. I am going to move it to the global scope, and remove it from being an injected constant, similar to how it is handled by Angular - https://github.com/angular/angular.js/blob/master/src/ng/directive/ngShowHide.js

@mikemclin
Copy link
Owner

Thanks for the contribution!

@sindhushaballa
Copy link
Contributor Author

Hi @mikemclin

You are welcome and it's a good plugin.

@sindhushaballa sindhushaballa deleted the 0.1.8-fix branch March 1, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants