Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing variable declaration #22

Closed
sgajavada opened this issue Aug 18, 2015 · 1 comment
Closed

Missing variable declaration #22

sgajavada opened this issue Aug 18, 2015 · 1 comment

Comments

@sgajavada
Copy link
Contributor

We are currently using this module and ran into an issue with this module where it seem to miss a variable declaration (missing var for matches) and pushes the variable to global scope (essentially global variable leak).

https://github.com/themikenicholson/passport-jwt/blob/master/lib/auth_header.js#L9
@mikenicholson
Copy link
Owner

Merged #23 to fix

mikenicholson added a commit that referenced this issue Sep 17, 2015
@mikenicholson
[Update] v1.1.0 -> v1.1.1
0f4ffa4 
Bug Fixes:
    #22 variable 'leaked' into global space
    #17 potential crash if request.url is missing token property
Misc:
   Various README cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikenicholson @sgajavada