-
-
Notifications
You must be signed in to change notification settings - Fork 116
Conversation
This reverts commit 08fc93d.
@@ -36,7 +36,9 @@ | |||
}, | |||
"dependencies": { | |||
"htmlparser2": "^3.8.3", | |||
"lodash": "^3.9.3" | |||
"lodash.foreach": "^4.1.0", | |||
"lodash.compact": "^3.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@no23reason Could that be 4.1.0
as well or is there a reason this is 3.0.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modularized lodash packages' versions do not always correspond with the current lodash version, they are versioned independently.
@no23reason Could you please update your branch with the latest from |
# Conflicts: # lib/process-node-definitions.js
…endency declarations
I merged your current |
Updated the |
More merge conflicts @no23reason... Do you mind updating your branch once again? My apologies for that, I learned my lesson and have to make sure PRs get dealt with asap going forward 😉 |
# Conflicts: # lib/parser.js
…, added the whole lodash as a devDependency as it is used in tests
It's ok, @mikenikles, I'm glad I could help 😄 the conflicts are resolved now |
👍 Merging this now, finally 😄 |
Simplified lodash dependencies so as to use only the functions needed. The reason for this is that when using this package on client, including the whole lodash makes the bundle unnecessarily big. Also simplified the condition in
lib/process-node-definitions.js
.This PR should also resolve #23.