Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Use modularized lodash #25

Merged
merged 8 commits into from
Apr 27, 2016
Merged

Use modularized lodash #25

merged 8 commits into from
Apr 27, 2016

Conversation

no23reason
Copy link
Contributor

Simplified lodash dependencies so as to use only the functions needed. The reason for this is that when using this package on client, including the whole lodash makes the bundle unnecessarily big. Also simplified the condition in lib/process-node-definitions.js.

This PR should also resolve #23.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 08fc93d on no23reason:master into 3bf4bd4 on mikenikles:master.

@@ -36,7 +36,9 @@
},
"dependencies": {
"htmlparser2": "^3.8.3",
"lodash": "^3.9.3"
"lodash.foreach": "^4.1.0",
"lodash.compact": "^3.0.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@no23reason Could that be 4.1.0 as well or is there a reason this is 3.0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modularized lodash packages' versions do not always correspond with the current lodash version, they are versioned independently.

@mikenikles
Copy link
Owner

@no23reason Could you please update your branch with the latest from master? Thanks

Dan Homola added 2 commits April 26, 2016 09:09
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 50ac6e6 on no23reason:master into f1efdbb on mikenikles:master.

@no23reason
Copy link
Contributor Author

I merged your current master and added a dependency for another lodash function used in it (contains).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c387a10 on no23reason:master into f1efdbb on mikenikles:master.

@no23reason
Copy link
Contributor Author

Updated the lodash.contains dependecy to lodash.includes as lodash.contains is deprecated.

@mikenikles
Copy link
Owner

More merge conflicts @no23reason... Do you mind updating your branch once again? My apologies for that, I learned my lesson and have to make sure PRs get dealt with asap going forward 😉

…, added the whole lodash as a devDependency as it is used in tests
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9d00351 on no23reason:master into a0cfb14 on mikenikles:master.

@no23reason
Copy link
Contributor Author

It's ok, @mikenikles, I'm glad I could help 😄 the conflicts are resolved now

@mikenikles
Copy link
Owner

👍 Merging this now, finally 😄

@mikenikles mikenikles merged commit 97587cd into mikenikles:master Apr 27, 2016
@mikenikles mikenikles modified the milestone: v1.0.0 May 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants