fix python3 compat issue #10
Conversation
|
Ooops, I missed #4 ... |
Removed Unipath dependency as it claims to support Python 3, but has an open issue regarding Python 3 support <mikeorr/Unipath#10>. Removed argparse dependency as Python 2.7 and 3.2 included argparse in stdlib. Furthermore some PEP8 cleanups on the files touched.
|
Too bad this hasn't been merged yet. However I would suggest that you invert the logic in your version test. Instead of testing for Python 3 test for 2. That way an eventual Python 4 will not break. |
|
I didn't see this issue somehow. I thought the Python 3 work was done. I'll add it to my todo list. I'm also looking at a version of Unipath on top of the new pathlib. However, the last time I looked at the pathlib on PyPI it wasn't up to date with the version in Python 2.4. |
|
I am getting this error when running "import unipath" in Python 3.4.0: _base = os.path.supports_unicode_filenames and unicode or str Is this a compatibility issue, or I need to import something else, for unicode to be recognized? Thanks, |
|
See #4. 'unicode' doesn't exist in Python 3. I haven't yet looked to see why my unit tests didn't catch this. |
Removed Unipath dependency as it claims to support Python 3, but has an open issue regarding Python 3 support <mikeorr/Unipath#10>. Removed argparse dependency as Python 2.7 and 3.2 included argparse in stdlib. Furthermore some PEP8 cleanups on the files touched.
|
Fixed in 5f5dfdf. Details in issue 16. Your code is better than mine was but it has one flaw: if the 'except' stanza executes and |
I found an NameError on Python 3.3.2, and propose small change to fix it.