Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build number not working with autopacker #6

Closed
fdellwing opened this issue Jun 11, 2017 · 4 comments
Closed

build number not working with autopacker #6

fdellwing opened this issue Jun 11, 2017 · 4 comments

Comments

@fdellwing
Copy link
Contributor

The build number ingame is not present if downloaded from curse (alpha version). Is there a way to fix this?

@IrcDirk
Copy link
Collaborator

IrcDirk commented Jun 11, 2017

Dont know. Curse makes its own repo clone and from its own repo makes downloads.

@fdellwing
Copy link
Contributor Author

Ok, there is this article: https://www.curseforge.com/knowledge-base/world-of-warcraft/532-repository-keyword-substitutions

I think, this one is the correct thing: @project-revision@

We need to push it to Curse to see it's effect, I will do a PR to test this,

@fdellwing
Copy link
Contributor Author

Works, but seems a bit long? We could format it to 9 chars (short git commit hash) or try another keyword like @project-abbreviated-hash@

Maybe just get them all into the code for your next commit as comment and decide afterwards what to do?

wowscrnshot_061117_203003

@IrcDirk
Copy link
Collaborator

IrcDirk commented Jun 11, 2017

Thats ok ill just make substring from this.

@IrcDirk IrcDirk closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants