Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations that call out to go-jira editor go screwy and prevent continuing in UI. #8

Closed
mikepea opened this issue Jan 6, 2016 · 1 comment

Comments

@mikepea
Copy link
Owner

mikepea commented Jan 6, 2016

I'm not sure why yet, but I can't seem to get go-jira editor operations (eg 'edit', 'comment') to return successfully to the termui interface.

A workaround is to simply exit after the operation, which is awful but better than hanging the UI.

Logging this ticket to track progress on fixing it.

mikepea pushed a commit that referenced this issue Jan 6, 2016
'E' edits the current ticket on both List and Show pages (basically where we
have an obvious ticketId available)

This fixes #2, but opens #8 - CmdEdit() requires that we close down
termui, as it needs control of the keyboard (fine).

However, I've not yet found a way of implementing this so that we can
subsequently re-enter the termui control. Meh. Hence #8.

Same problemw will happen with all editor based operations, #8 covers them.
mikepea pushed a commit that referenced this issue Jan 6, 2016
This fixes #9, though still suffering from #8.

I'm not particularly happy here though, the edit interface provided lacks context: it simply
is a raw YAML 'body: |' prompt in $EDITOR. Not very friendly.

Unfortunately, the data is just not available to the 'comment' template to put a reference
to the ticket id and summary into place, so I think this requires a PR to go-jira :(
@mikepea
Copy link
Owner Author

mikepea commented May 7, 2016

This issue seems to boil down to an inability to remove event handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant