Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More optimal use of method String.IndexOf #843

Merged
merged 2 commits into from Jul 1, 2021
Merged

More optimal use of method String.IndexOf #843

merged 2 commits into from Jul 1, 2021

Conversation

SergerGood
Copy link
Collaborator

No description provided.

@mikependon
Copy link
Owner

Hey mate, thanks for this PR 🚀 Btw, if I accept the renaming of the StringConstant to CharConstant, then it might limit the possibilities of this class to be more extensible for other constants (i.e.: Strings, Formatting String, etc). I suggest to rename the file back to StringConstant and create a separate class CharConstant. Is that feasible for this PR?

@SergerGood
Copy link
Collaborator Author

SergerGood commented Jul 1, 2021 •
edited

Hey! I didn't change the file, I added a new one ;) I just put it in a separate folder.

@mikependon mikependon merged commit b0abde2 into master Jul 1, 2021
@SergerGood SergerGood deleted the more-optimal-using-stings branch July 1, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergerGood @mikependon