Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Set the return value of Max and Min operations to object. #357

Closed
mikependon opened this issue Dec 17, 2019 · 2 comments
Closed

Bug: Set the return value of Max and Min operations to object. #357

mikependon opened this issue Dec 17, 2019 · 2 comments
Assignees
Labels
bug Something isn't working deployed Feature or bug is deployed at the current release priority Top priority feature or things to do

Comments

@mikependon
Copy link
Owner

mikependon commented Dec 17, 2019

Currently, the implementation is only returning the long data type which is a bit limited. We need to make sure that the return type would be of type object to support all return types.

Calls:

connection.Max<Entity>(e => e.DateTime);
connection.Max<Entity>(e => e.Int32);
connection.Max<Entity>(e => e.Double);

Acceptance Criteria:

All affected Integration Tests and Unit Tests must be fixed and passing.

@mikependon mikependon added bug Something isn't working priority Top priority feature or things to do labels Dec 17, 2019
@mikependon mikependon self-assigned this Dec 17, 2019
@mikependon
Copy link
Owner Author

The fix will be available at version > v1.10.1-alpha1.

@mikependon mikependon added the deployed Feature or bug is deployed at the current release label Dec 18, 2019
@mikependon
Copy link
Owner Author

Is now available at RepoDb.MySql (v1.0.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployed Feature or bug is deployed at the current release priority Top priority feature or things to do
Projects
None yet
Development

No branches or pull requests

1 participant