Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Navigation Compatibility #2437

Closed
guger opened this issue Apr 1, 2019 · 9 comments · Fixed by #2471
Closed

Jetpack Navigation Compatibility #2437

guger opened this issue Apr 1, 2019 · 9 comments · Fixed by #2471

Comments

@guger
Copy link

guger commented Apr 1, 2019

Is this library compatible with AndroidX Jetpack's Navigation-UI?

e.g. mDrawer.setupWithNavController(...)

@mikepenz
Copy link
Owner

mikepenz commented Apr 1, 2019

There is no direct dependency to it. This library provides all listeners and callback you might need to implement navigation.

@mikepenz mikepenz self-assigned this Apr 1, 2019
@guger
Copy link
Author

guger commented Apr 2, 2019

Would it be a possibility feature/improvement?

Actually, this is the only reason why I don't want / can't use this library...

@mikepenz
Copy link
Owner

mikepenz commented Jun 8, 2019

Currently I have no plan yet to directly integrate as it should be possible out of the box via using the listeners. and invoke the relevant calls.

It might also be possible to write a plugin which hooks up a listener and coordinates with the navigation components if required.

I am open for more input of people if that is really needed to improve

@kibotu
Copy link

kibotu commented Jul 23, 2019

not sure why but in my current project the combination of material drawer library, BottomNavigationView and jetpack navigation components leads to a weird bug where the current fragment gets zero width/height after few navigations (just tabbing bottom navigation tabs few times)

it only occurs when i have material drawer added

@mikepenz
Copy link
Owner

@kibotu I am 99% sure that you have a version conflict. The latest MaterialDrawer RC uses the Material Components 1.1.0-beta08 due to the Shape framework which was embedded into the drawer.

If you used older versions of the MaterialComponents that most likely will cause conflicts

@kibotu
Copy link

kibotu commented Jul 24, 2019

thanks for the info @mikepenz, i will check the versions throughout the project

@DanteAndroid
Copy link

@mikepenz Could you provide a document or sample to show how to integrate Navigation with MaterialDrawer

@DanteAndroid
Copy link

@mikepenz That's fast. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants