Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descripdescriptionTextColor not work for PrimaryDrawerItem in 8.0.0-b03 #2564

Closed
beeline09 opened this issue Feb 27, 2020 · 1 comment
Closed
Assignees
Labels

Comments

@beeline09
Copy link

beeline09 commented Feb 27, 2020

I test two variants:

val itemSync = PrimaryDrawerItem().apply {
            name = StringHolder("Получение справочников")
            description = StringHolder("Посл.раз: $lastDateSync")
            descriptionTextColor = ColorHolder.fromColor(color_int)
            identifier = Constants.MATERIAL_DRAWER.ITEM_IDS.SYNC_GET_REFERENCES
            icon = ImageHolder(R.drawable.ic_sync_black_50dp)
        }
        
val itemSync = PrimaryDrawerItem().apply {
            name = StringHolder("Получение справочников")
            description = StringHolder("Посл.раз: $lastDateSync")
            descriptionTextColor = ColorHolder.fromColor(Color.RED)
            identifier = Constants.MATERIAL_DRAWER.ITEM_IDS.SYNC_GET_REFERENCES
            icon = ImageHolder(R.drawable.ic_sync_black_50dp)
        }

and i see that descriptionTextColor not working.
Screenshot_1582792633

@mikepenz mikepenz self-assigned this Feb 27, 2020
@mikepenz mikepenz added the bug label Feb 27, 2020
@mikepenz
Copy link
Owner

Thanks. You are right this was no longer forward ported with v8. I have fixed it by simplifying the api and enhancing it by allowing a ColorStateList instead of a single color.

The preferred approach for coloring items would still be to define the colors via the theme as expected. You might want to look into this.

Fix published in v8.0.0-b04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants