Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't record circ results for cbtverify if CBT is reset #58

Closed
mikeperry-tor opened this issue Oct 9, 2020 · 1 comment
Closed

Don't record circ results for cbtverify if CBT is reset #58

mikeperry-tor opened this issue Oct 9, 2020 · 1 comment

Comments

@mikeperry-tor
Copy link
Owner

With onionperf, we are testing circuit build timeout performance effects: https://gitlab.torproject.org/tpo/core/tor/-/issues/40157

To do this, we need to verify that CBT is properly timing out the right amount of onion circuits and normal circuits. The cbtverify component of vanguards can help with this, but it did not know about the BUILDTIMEOUT_SET RESET event. We need to teach it not to record timeouts during this time between RESET and computed, and also reset stats upon RESET.
mikeperry-tor pushed a commit that referenced this issue Oct 9, 2020
Issue #58: Ignore circuits between CBT RESET and COMPUTED
77456dc 
Note that when vanguards is first attached, it assumes the CBT is already
computed. This may not be true if a fresh vanguards is attached to a fresh
Tor.
@mikeperry-tor
Copy link
Owner Author

This is fixed and documented in the changelog, so I'm closing this.

mikeperry-tor pushed a commit that referenced this issue Apr 1, 2021
Issue #58: Fix unittest failure for cbtverify
b161148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikeperry-tor