Skip to content

Commit

Permalink
correct sstable thread guidance after changing to cached readers
Browse files Browse the repository at this point in the history
  • Loading branch information
mikerhodes committed Apr 29, 2024
1 parent 46ef2c0 commit 47697c6
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/sstable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ use crate::kvrecord::{KVRecord, KVWriteRecord};
/// As this is toykv and not productionkv, we use a very
/// simple file format of KVRecords streamed to disk.
///
/// Implementation is NOT thread safe. A Writer should
/// have exclusive use of a dir, whereas multiple readers
/// can safely access concurrently.
/// Implementation is NOT thread safe. We hold open BufReaders
/// to files, so multiple readers would stomp all over each
/// other. Multiple writers, meanwhile, would just totally
/// make a mess that probably wouldn't be recoverable.

/// Manage and search a set of SSTable files on disk.
pub(crate) struct SSTables {
Expand Down

0 comments on commit 47697c6

Please sign in to comment.