Report for 'Constant string in component HTML attributes #478'. New t…

[jccazeaux]

…ests for components reveal an error in forEach on attributes: attributes is not an array. An error was revealed too in View import : cyclic dependency between view and binding;

Two important notes on this report

1. Import of View from module view.js couldn't be resolved because view.js already used bindings.js in his imports. To break this cycle i replace new View by rivets.bind() which provides exactly the same result.
2. I introduced all components tests given by @blikblum. This revealed a bug due to use of forEach on element attributes. attributes is not an array and can not be browsed with forEach.

[blikblum]

You can use Array.prototype.slice.call(this.el.attributes).forEach(attribute => ...)
or
Array.prototype.forEach.call(this.el.attributes, attribute => ...)

[jccazeaux]

Yes i'm a bit old school on loops ;)
But as for() loops are faster than forEach i think it's not that bad.

[stalniy]

why do you create it here? I believe you can remove this line and move let on 283

[jccazeaux]

It's an old java reflex. I never declare variables in loops. I know in javascript it isn't as important but sometimes i can't help it ;)