Extend logging of proceedToAfterExecSpinlocks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ties in with balderdashy/sails#4502 and balderdashy/sails#4400 While @mikermcneil has valid points that we *should* be using async/await, there are times when callbacks are still used and the message/trace inside `errCbArg` would otherwise be lost.
|
FYI I tested this on a traditional callback that was throwing an error and errCbArg is |
|
@drj-io I think you're running an older version maybe? Older versions of sails/waterline/etc as suggested by the stack trace at balderdashy/sails#4400 (comment) give this a try balderdashy/sails#4377 (comment) On latest |
|
@drj-io thanks for looking into it! @wulfsolter This makes sense. Instead of "here is errCbArg", how do you feel about "here is the original error"? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ties in with balderdashy/sails#4502 and balderdashy/sails#4400
While @mikermcneil has valid points that we should be using async/await, there are times when callbacks are still used and the message/trace inside
errCbArgwould otherwise be lost.