-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No large book covers and white screen with vienwer #73
Comments
There was an error for multi-database that should be fixed in the latest release 2.2.2, but that was only for epub reader and email. I'm not sure I understand the errors you mentioned here - what did you mean by selecting a book cover and scroll horizontally for Error 1, and what did you mean by "selecting view icon" only for Error 2? |
I will install version 2.2.2 tomorrow and report back. I like to fix 1 error at a time ;-) |
@mikespub Error 1 (additional explanation): In the legacy COPS I could click on a cover in this view: Selecting a book goes through clicking on the title (not on the cover/icon). I like my old COPS back ;-) Keep up the great work!!! |
Hi @marioscube - about Error 1 that's what I thought you meant, and it's a nice feature indeed :-) But here's my problem: in the original COPS code at https://github.com/seblucas/cops and further releases here at https://github.com/mikespub-org/seblucas-cops there is no code, template or javascript that supports this... Can you find out which version you were based on, and if there was anything customized after this version from elsewhere, so that I can recreate this? Thanks |
Changes in ../cops/templates/default/main.html and or ../cops/templates/default/bookdetail.html seem to be the cause. |
Aha, we're getting closer - between 1.4.2 and 1.4.3 I did indeed switch the link on the thumbnail image in the main.html template from coverURL (fetch.php?id=...) to detailURL (index.php?page=13&id=...), because ... in the main navigation it made more sense to point to the detail page and it seemed pointless to link to a cover image by itself. Of course, at that point I did not have that functionality with previous & next buttons in the interface that you showed here either - so I still don't know if & when that actually disappeared. Did you have any other customization of templates or javascript by any chance, or do you still have this working with 1.4.2? |
That functionality has been in COPS since almost forever. If I, just for testing purposes, copy the html files from version 1.4.2 to version 2.2.2 this works again. |
Thanks for the clarifications & screenshots. When trying to reproduce this, I noticed that you used the "Lightbox" option (magnific popup) for the default template, which actually still works for 2.2.2+ when it gets the right cover url - now fixed with the changes above :-) |
I have my old COPS back, now working with php8. Thank you! Issue closed! |
Running:
Error 1:
Error 2
Am I doing something wrong?
The text was updated successfully, but these errors were encountered: