Util.js to es5 #58
Merged
Util.js to es5 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore debugging files and vscode config
|
I realised I could run util.js through chatGPT and ask it what wasn't valid ES5. It identified the use of |
|
I didn't need to roll back all the changes :-) Still learning. |
|
Thanks @dunxd - if we ever expand what's in util.js I would indeed consider splitting off an ES5 variant for very old e-readers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default values for function parameters were introduced in ES6. Old Kindle's Experimental Browser only supports ES5 features. I've changed the way that a default is handled, based on a method found on StackOverflow, and it works ok.
The initiateTwigged function that we moved earlier doesn't appear to use this, but I expect the issue is related to an unsupported language feature too.