Render custom (long-text) columns with whitespace: pre-wrap #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - I haven't really played with display options in Calibre for custom columns, but if it works for you that's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we show the content of a custom column of type
comments(in the book preview) we loose all line-breaks and leading whitespaces.This commit PR parses the
displaycolumn from the database and addswhite-space: pre-wrap, to properly render the content (ifinterpret_asis eitherhtml,long-textormarkdown).For the fourth possible interpret-as value
short-text, we keep the currentdisplay: inlinebehavior.In the future it could be nice to really render the content if
interpret_asishtmlormarkdown. (Markdown would be pretty easy, but html would need a proper html sanitizer to prevent XSS)...