Improve email #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix getCurrentOption() so it can get email addresses - previous regex did not allow it. There may be better options using filter_var().
Limit to sending to 5 addresses. Note that the cookie extraction doesn't allow the ; delimiter, so this is to prevent mischief. Check that email addresses are valid using PHP built in function filter_var().
Limit sending to a single email address, which must be valid.
Bugfix
|
Thanks @dunxd - seems like the feature branch approach worked well for you, as I updated the main branch in parallel :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit sending to a single email address which must be valid. (Previously the code exploded a list of email addresses delimited with
;, however the cookie extraction code didn't allow that character, and there really is no good reason to allow sending to more than one address in one step.Fix bug that prevented configured email address from being displayed on customisation page.