Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mike 👋🏾
This change removes the
redis-cli
andpsql
dependencies from the users computer. The make targets have been updated to use the binaries of those tools from within the docker container themselves. Because the ports are forwarded from the host computer to within docker, this will work exactly the same as before (except now the queries are running directly within the container instead of on the host).I found this to be necessary because when I installed postgres locally my machine, it conflicted with the port binding from within docker when running
docker compose up
. My solution was to remove the localpsql
binary and just execute from within the container. (note: i'm runningPop!_OS 22.04 LTS x86_64
).This change also updates the
docker compose
plugin to the correct syntax for the latest version (3). It is no longer a separate binary, rather an argument on thedocker
command itself.Hope this makes sense & may helps others as well.
Thank you again for the wonderful go web starter kit - it saved me a lot of time 🥇
-- Ahmed