Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerizing db and cache #14

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

ahashim
Copy link
Contributor

@ahashim ahashim commented Oct 9, 2022

Hi Mike 👋🏾

This change removes the redis-cli and psql dependencies from the users computer. The make targets have been updated to use the binaries of those tools from within the docker container themselves. Because the ports are forwarded from the host computer to within docker, this will work exactly the same as before (except now the queries are running directly within the container instead of on the host).

I found this to be necessary because when I installed postgres locally my machine, it conflicted with the port binding from within docker when running docker compose up. My solution was to remove the local psql binary and just execute from within the container. (note: i'm running Pop!_OS 22.04 LTS x86_64).

This change also updates the docker compose plugin to the correct syntax for the latest version (3). It is no longer a separate binary, rather an argument on the docker command itself.

Hope this makes sense & may helps others as well.

Thank you again for the wonderful go web starter kit - it saved me a lot of time 🥇

-- Ahmed

@mikestefanello mikestefanello merged commit 434d7b4 into mikestefanello:main Oct 10, 2022
@mikestefanello
Copy link
Owner

Hey. Thanks for the kind words and for this needed improvement. I'm glad to hear these project has been helpful to you.

@ahashim ahashim deleted the dockerizing-db-and-cache branch October 11, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants