fixes Issue 45 - cant generate using ent and then run #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedw99
changed the title
|
https://github.com/mikestefanello/pagoda/blob/main/pkg/context/context_test.go#L21 is the source of a test failure on my laptop. It's minor I think. Not sure if it was there before |
|
@mikestefanello do you require that PRs be signed ? |
|
Thanks for taking care of this. I'll fix the context_test issue now. |
mikestefanello
approved these changes
Nov 16, 2023
thanks @mikestefanello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45
Al I did was run go-mod-upgrade and go mod tidy
https://github.com/oligot/go-mod-upgrade
This does a sweep through everything. I updated to all latest dependencies, and did a generate and run and test.
This is my first PR, so if I missed something or should have done it on a branch, let me know.