Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformats all cells to square shape #3

Open
AJMiller opened this issue Apr 23, 2015 · 1 comment
Open

Reformats all cells to square shape #3

AJMiller opened this issue Apr 23, 2015 · 1 comment

Comments

@AJMiller
Copy link

Noticed that when calculating the spacing, that JBSpacer takes a CGFloat for itemSize. If it took a CGSize parameter instead, it could include the height of the cell as it's already been defined, instead of applying itemSize to both the width and the height of the cell. This effectively bars any user from passing in a rectangular cell and having just the gutter width modified. Right now, it appears to assume that itemSize should be used for both width and height and resizes all cell heights to match itemSize.
@eranmarom
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AJMiller @eranmarom