Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmb.NetBIOS.NetBIOS.queryName should call self.prepareNameQuery with the is_broadcast keyword argument #67

Open
dardyfella opened this issue Sep 1, 2016 · 0 comments

Comments

@dardyfella
Copy link

When a nmb.NetBIOS.NetBIOS object is created with the broadcast keyword parameter set to False and nmb.NetBIOS.NetBIOS.queryName is called with the ip keyword argument no reply will be received because a query packet with the broadcast flag set is still being sent. I propose the following change to correct this:

In nmb.NetBIOS.NetBIOS.queryName this line:
data = self.prepareNameQuery(trn_id, name)

Should become this line:
data = self.prepareNameQuery(trn_id, name, is_broadcast = self.broadcast)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant