Allow resetFileAttributes to set specific attributes.
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketeo
added a commit
that referenced
this pull request
Oct 18, 2020
|
@benmoran56 : Thank you for your patch. I'm agreeable with using the same function name for this purpose. Creating another setFileAttributes function will bloat the API unnecessarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the
resetFileAttributemethod to optionally specify thefile_attributes.If no attribute is specified, then the behavior is identical to before (attributes are set to ATTR_ARCHIVE).
I was considering making a new method for this, but it seemed less bloated to just extend the existing method.
Comments welcome!