## COOK-1280: #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2012 19:18
* Change nginx['user'] to `nginx` on redhat platform * Change nginx['init_style'] to `init` on redhat platform * Create non-existing `sites-enabled` and `sites-available` directories on redhat platform * Add redhat family platforms to supported OS list * Update README to note nginx is availabe only by EPEL on redhat platform * Remove template notify for non-existent ohai[custom_plugins] resource, and move `include_recipe "ohai"` a general fix for all platforms. ## v0.101.2: * [COOK-1211] - include the default attributes explicitly so version is available. ## v0.101.0: **Attribute Change**: `node['nginx']['url']` -> `node['nginx']['source']['url']`; see the README.md. * [COOK-1115] - daemonize when using init script * [COOK-477] - module compilation support in nginx::source ## v0.100.4: * [COOK-1126] - source version bump to 1.0.14 ## v0.100.2: * [COOK-1053] - Add :url attribute to nginx cookbook ## v0.100.0: * [COOK-818] - add "application/json" per RFC. * [COOK-870] - bluepill init style support * [COOK-957] - Compress application/javascript. * [COOK-981] - Add reload support to NGINX service ## v0.99.2: * [COOK-809] - attribute to disable access logging * [COOK-772] - update nginx download source location
* Remove unnecessary include_attribute "nginx", already in the same attribute scope * Convert definition to compatible LWRP for *foodcritic*
| end | ||
|
|
||
| default[:nginx][:pid] = "/var/run/nginx.pid" | ||
| default[:nginx][:install_method] = 'package' |
There was a problem hiding this comment.
Where'd this attribute go? We relied on it in the default recipe...
* Revert LWRP conversion * Revert accidental squash of nginx::commons refactor chef-client Log: [Wed, 13 Jun 2012 20:44:06 -0400] INFO: *** Chef 0.10.8 *** [Wed, 13 Jun 2012 20:44:07 -0400] INFO: Run List is [recipe[nginx]] [Wed, 13 Jun 2012 20:44:07 -0400] INFO: Run List expands to [nginx] [Wed, 13 Jun 2012 20:44:07 -0400] INFO: Starting Chef Run for cheftrain08.marshall.edu [Wed, 13 Jun 2012 20:44:07 -0400] INFO: Running start handlers [Wed, 13 Jun 2012 20:44:07 -0400] INFO: Start handlers complete. [Wed, 13 Jun 2012 20:44:07 -0400] INFO: Loading cookbooks [bluepill, build-essential, nginx, ohai, runit, yum] [Wed, 13 Jun 2012 20:44:07 -0400] INFO: ohai plugins will be at: /etc/chef/ohai_plugins [Wed, 13 Jun 2012 20:44:14 -0400] INFO: package[nginx] installed version 1.0.15-2.el6 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: service[nginx] enabled [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/var/log/nginx] owner changed to 497 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-available] created directory /etc/nginx/sites-available [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-available] owner changed to 0 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-available] group changed to 0 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-available] mode changed to 755 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-enabled] created directory /etc/nginx/sites-enabled [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-enabled] owner changed to 0 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-enabled] group changed to 0 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: directory[/etc/nginx/sites-enabled] mode changed to 755 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: template[nginx.conf] backed up to /var/lib/chef/etc/nginx/nginx.conf.chef-20120613204414 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: template[nginx.conf] mode changed to 644 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: template[nginx.conf] updated content [Wed, 13 Jun 2012 20:44:14 -0400] INFO: template[nginx.conf] sending reload action to service[nginx] (immediate) [Wed, 13 Jun 2012 20:44:14 -0400] INFO: template[/etc/nginx/sites-available/default] mode changed to 644 [Wed, 13 Jun 2012 20:44:14 -0400] INFO: template[/etc/nginx/sites-available/default] updated content [Wed, 13 Jun 2012 20:44:14 -0400] INFO: execute[nxensite default] sh(/usr/sbin/nxensite default) [Wed, 13 Jun 2012 20:44:14 -0400] INFO: execute[nxensite default] ran successfully [Wed, 13 Jun 2012 20:44:14 -0400] INFO: service[nginx] started [Wed, 13 Jun 2012 20:44:14 -0400] INFO: execute[nxensite default] sending reload action to service[nginx] (delayed) [Wed, 13 Jun 2012 20:44:14 -0400] INFO: service[nginx] reloaded [Wed, 13 Jun 2012 20:44:15 -0400] INFO: Chef Run complete in 7.924041191 seconds [Wed, 13 Jun 2012 20:44:15 -0400] INFO: Running report handlers [Wed, 13 Jun 2012 20:44:15 -0400] INFO: Report handlers complete
|
Pretty sure I accidentally squashed out the nginx::commons stuff using either an older version from the community site, or perhaps the most current version from community site without those changes. Either way, the 4d87e83c commit reverts the damage to that commit, and also reverts the LWRP conversion of the definition. |
|
<3, thanks Eric! Will review tomorrow. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginxon redhat platforminiton redhat platformsites-enabledandsites-availabledirectories on redhat platforminclude_recipe "ohai"a general fix for all platforms.