Improve fixtures to not affect other tests

[emontnemery]

Make sure fixtures socket_disabled and socket_enabled do not affect other tests

[codeclimate]

Code Climate has analyzed commit 8685da7 and detected 0 issues on this pull request.

View more on Code Climate.

[miketheman]

Thanks! Can you help me understand how this was a problem, and why this solves it? Even better with a test suite that proves the problem!

[emontnemery]

Example:

"""Example test."""
import socket

def test_1(socket_enabled):
    ...

def test_2():
    socket.socket()

This will pass:

pytest tests/disable_socket_test.py::test_2

This will fail on tests/disable_socket_test.py::test_2 because test_1 will disable sockets:

pytest tests/disable_socket_test.py

[emontnemery]

@miketheman Do you still need some more clarifications for this PR?

[miketheman]

@emontnemery I'm actually working through the precedence logic - see #81 for more - so I'm holding off on changes to the fixture behavior right now until I get more of that done.

[miketheman]

@emontnemery I think that the changes in #90 should help here. would you mind testing the plugin from main branch out for your scenario? The test teardown now restores the true socket instead of trying to manipulate the state.

[emontnemery]

Yes, the change from #90 does indeed seem to work fine 👍