✨ Emit timing from a block even if raised #3

miketheman · 2016-06-30T15:19:32Z

In the event of a yield raising, we never get timings. Wrapping in
ensure should emit the timing no matter what.

Hat-tip to @kostya !

Closes #2

@kostya

In the event of a yield raising, we never get timings. Wrapping in `ensure` should emit the timing no matter what. Hat-tip to @kostya ! Closes #2

miketheman · 2016-06-30T15:22:21Z

@kostya thanks, and would appreciate your review here.

kostya · 2016-06-30T15:27:53Z

👍

btw just trying to use this shard in prod, but something not working (stats not appearing), not find a reason right now, ruby gem worked immideaetelly.

✨ Emit timing from a block even if raised

92c8e8e

In the event of a yield raising, we never get timings. Wrapping in `ensure` should emit the timing no matter what. Hat-tip to @kostya ! Closes #2

miketheman added the enhancement label Jun 30, 2016

miketheman merged commit e9588b9 into master Jun 30, 2016

miketheman deleted the miketheman/time_raise branch June 30, 2016 15:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Emit timing from a block even if raised #3

✨ Emit timing from a block even if raised #3

miketheman commented Jun 30, 2016

miketheman commented Jun 30, 2016

kostya commented Jun 30, 2016 •

edited

✨ Emit timing from a block even if raised #3

✨ Emit timing from a block even if raised #3

Conversation

miketheman commented Jun 30, 2016

miketheman commented Jun 30, 2016

kostya commented Jun 30, 2016 • edited

kostya commented Jun 30, 2016 •

edited