Refactor to improve it a bit

mikevallano · Dec 1, 2019 · 9a1ba63 · 9a1ba63
1 parent e352b27
commit 9a1ba63
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/app/models/user.rb b/app/models/user.rb
@@ -62,8 +62,8 @@ def all_listings
   end
 
   def lists_except_movie(movie = nil)
-    if movie.present? && existing_movie = Movie.find_by(tmdb_id: movie.tmdb_id)
-      (all_lists - existing_movie.lists.by_user(self))
+    if movie.present? && movie.in_db
+      (all_lists - movie.lists.by_user(self))
         .sort_by { |list| list.name.downcase }
     else
       all_lists_by_name

diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
@@ -57,6 +57,11 @@
       expect(user.lists_except_movie(movie)).to include(list2)
     end
 
+    it "responds to lists_except_movie" do
+      list2
+      expect(user.lists_except_movie).to match_array([list, list2])
+    end
+
     it "responds to all_movies" do
       expect(user).to respond_to(:all_movies)
     end
@@ -105,4 +110,4 @@
     end
   end
 
-end #final
+end #final