214: Fix Youtube URL parsing

[mikevallano]

Related Issues & PRs

Closes #214

Problems Solved

• Now you can paste youtube urls with whatever additional url params are there
• FULLSCREEN MODE now works! 🎉

Screenshots

Fullscreen mode and licecap don't work together, but it works!

Things Learned

• I modified the code from this SO post: https://stackoverflow.com/a/6557013
• We should probably put some sort of validation in place to ensure nobody can enter invalid stuffs. Since we don't currently have it, I'll open a separate issue for it.

[lortza]

We may want to add a couple of more cases in here to cover some of the logic in these private methods:

Suggested change

	it 'leaves non-youtube urls as-is' do
	original_trailer = 'https://www.example.com'
	patch :update,
	{ id: movie.id,
	tmdb_id: movie.tmdb_id,
	trailer: original_trailer }
	expect(movie.reload.trailer).to eq(original_trailer)
	end
	it 'handles empty trailer urls' do
	trailer = ''
	patch :update,
	{ id: movie.id,
	tmdb_id: movie.tmdb_id,
	trailer: trailer }
	expect(movie.reload.trailer).to eq(trailer)
	end

[mikevallano]

🤔 I did add those, but it's a bit weird because that's not how we want it to work.

But since it is how it works, I agree it'd be helpful to have the tests there.

I put them in a context and added a comment referencing the other issue that aims to fix it.

[lortza]

When I was reading this, I was a little confused about what was being returned. In one case, we're returning a whole url, in another, we're returning just a youtube_id, but it took me a beat to get there. When I rearrange the two methods like this, it's a little bit more clear to me. Of course, it's your call. I know ternaries aren't everyone's jam.

  def required_params
    trailer_url = params[:trailer]
    params[:trailer] = trailer_url.include?('youtube.com') ? youtube_id : trailer_url
    params.permit(:trailer)
  end

  def youtube_id
    uri = Addressable::URI.parse(params[:trailer])
    uri.query_values['v'] if uri.query_values
  end

[mikevallano]

👍 Ooh, me likey. Much better!