Enforce error_reporting level for phpunit suite #117
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the unit tests rely on phpunit's error handler throwing exceptions from various trigger_error calls. This error handler only fires for errors matching the system error_reporting configuration.
If the user's local error_reporting is configured too low then the test suite will produce a number of false failures and false positives - expected exceptions will not be thrown and code that is expected to abort will continue execution with the error message silenced. This caught me out when contributing #116
Add a custom bootstrap to ensure that PHP is configured to use E_ALL | E_STRICT for the duration of the test run regardless of the system default setting.