Skip to content

Commit

Permalink
Remove support for Python 2.x
Browse files Browse the repository at this point in the history
Arrested will no longer officially support python 2.x and as such
we will no longer test against python 2.x
  • Loading branch information
mikeywaites committed Nov 9, 2019
1 parent 6b97ce2 commit 7cac3c3
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 73 deletions.
47 changes: 0 additions & 47 deletions .circleci/config.yml
Expand Up @@ -27,26 +27,6 @@ jobs:
key: py3deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}
paths:
- "py3venv"
build-python2:
<<: *defaults
docker:
- image: python:2
steps:
- checkout
- restore_cache:
key: py2deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}
- run:
name: Install Python deps in a venv
command: |
[ -d py2venv ] && echo 'exists' || virtualenv py2venv
. py2venv/bin/activate
pip install -r requirements.txt
python setup.py develop
- save_cache:
key: py2deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}
paths:
- "py2venv"

test-python3:
<<: *defaults
docker:
Expand All @@ -65,26 +45,6 @@ jobs:
paths:
- "py3venv"
- ".coverage"

test-python2:
<<: *defaults
docker:
- image: python:2
steps:
- checkout
- restore_cache:
key: py2deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}
- run:
command: |
. ~/flask-arrested/py2venv/bin/activate
python setup.py develop
py.test -s --cov=arrested --cov-report=term-missing --tb=short tests/
- save_cache:
key: py2testreport-{{ .Branch }}-{{ .Revision }}
paths:
- "py2venv"
- ".coverage"

release:
<<: *defaults
docker:
Expand Down Expand Up @@ -125,11 +85,7 @@ workflows:
version: 2
build_test_and_deploy:
jobs:
- build-python2
- build-python3
- test-python2:
requires:
- build-python2
- test-python3:
requires:
- build-python3
Expand All @@ -140,13 +96,10 @@ workflows:
- master
- wip/version-0.1.0
requires:
- test-python2
- test-python3
- docs:
requires:
- test-python2
- test-python3
- coverage:
requires:
- test-python2
- test-python3
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,6 +1,11 @@
Changelog
========================

v2.0.0
----------------------

* Dropped support for Python 2.x

v0.1.3
-----------------------

Expand Down
11 changes: 0 additions & 11 deletions Dockerfile.py2

This file was deleted.

10 changes: 0 additions & 10 deletions docker-compose.yml
Expand Up @@ -12,16 +12,6 @@ services:
tty: true
stdin_open: true

py2:
build:
context: .
dockerfile: Dockerfile.py2
command: py.test -s --cov=arrested --cov-report=term-missing --tb=short tests/
volumes:
- .:/opt/code
tty: true
stdin_open: true

api:
build:
context: example/
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
@@ -1,6 +1,6 @@
pytest==3.2.1
pytest==5.2.2
sphinx
pytest-cov
pytest-cov==2.8.1
ipdb
flask_sqlalchemy
py-kim
Expand Down
1 change: 0 additions & 1 deletion run_unit_tests.sh
@@ -1,2 +1 @@
docker-compose run py2
docker-compose run py3
4 changes: 2 additions & 2 deletions setup.py
Expand Up @@ -23,12 +23,12 @@
'Intended Audience :: Developers',
'License :: OSI Approved :: MIT License',
'Operating System :: OS Independent',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Topic :: Internet :: WWW/HTTP',
'Topic :: Internet :: WWW/HTTP :: Dynamic Content',
'Topic :: Internet :: WWW/HTTP :: WSGI',
Expand Down

0 comments on commit 7cac3c3

Please sign in to comment.