Destination and Windows UNC path

[viceroycowboy]

Hello guys can you tell me how to download files correctly with a windows path like this

\192.168.2.200\username\folder\folder

now I have only

[twitter][error] Unable to download data: OSError: [WinError 123]

Can't mount folder like a network drive because VPN broadcasting issues

Python 3.10.1

[Hrxn]

ac80474

#2113 (comment)

[mikf]

\192.168.2.200\username\folder\folder

Don't UNC paths have to start with a double (back)slash? I'm asking because the code from ac80474 checks for just that to determin whether a path is UNC or not.

[Hrxn]

Yep, should be a double backslash.

Here's the syntax in ABNF taken from the MSFT docs for Windows Common Data Types:

 UNC                = "\\" host-name "\" share-name  [ "\" object-name ]
 host-name          = IPv6address / IPv4address / reg-name  
    ; IPv4address, and reg-name are as specified in [RFC3986], see following for IPV6
 share-name         = 1*80pchar
 pchar              = %x20-21 / %x23-29 / %x2D-2E / %x30-39 / %x40-5A / %x5E-7B / %x7D-FF  
 object-name        = *path-name [ "\" file-name ]
 path-name          = 1*255pchar
 file-name          = 1*255fchar [ ":" stream-name [ ":" stream-type ] ]
 fchar              = %x20-21 / %x23-29 / %x2B-2E / %x30-39 / %x3B / %x3D / %x40-5B / %x5D-7B / %x7D-FF 
 stream-name        = *schar
 schar              = %x01-2E / %x30-39 / %x3B-5B /%x5D-FF
 stream-type        = 1*schar

[AlttiRi]

Don't UNC paths have to start with a double (back)slash?

It's just the GitHub's editor turns \\ to \.

[viceroycowboy]

Guys soo how much backslashes I should use?

[Hrxn]

Two backslashes..

Like this:

\\192.168.2.200\username\folder\folder

[viceroycowboy]

Two backslashes..

Like this:

\\192.168.2.200\username\folder\folder

[twitter][error] Unable to download data: OSError: [WinError 123] Синтаксическая ошибка в имени файла, имени папки или метке тома: '\\'

[AlttiRi]

Well, with the last version, gallery-dl does not work when I run it in a network folder:

OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: '\\\\'

[gallery-dl][debug] Version 1.20.0-dev
[gallery-dl][debug] Python 3.9.9 

Traceback (most recent call last):
  File "...\Python\Python39\lib\site-packages\gallery_dl\job.py", line 80, in run
    self.dispatch(msg)
  File "...\Python\Python39\lib\site-packages\gallery_dl\job.py", line 124, in dispatch
    self.handle_url(url, kwdict)
  File "...\Python\Python39\lib\site-packages\gallery_dl\job.py", line 220, in handle_url
    pathfmt.set_filename(kwdict)
  File "...\Python\Python39\lib\site-packages\gallery_dl\path.py", line 202, in set_filename
    self.build_path()
  File "...\Python\Python39\lib\site-packages\gallery_dl\path.py", line 284, in build_path
    os.makedirs(self.realdirectory, exist_ok=True)
  File "...\Python\Python39\lib\os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "...\Python\Python39\lib\os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "...\Python\Python39\lib\os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  [Previous line repeated 2 more times]
  File "...\Python\Python39\lib\os.py", line 225, in makedirs
    mkdir(name, mode)

[AlttiRi]

A workable fix:

gallery-dl/gallery_dl/path.py

Lines 281 to 282 in 0bd7607

	def build_path(self):
	"""Combine directory and filename to full paths"""

self.realdirectory = self.realdirectory.replace("\\\\?\\\\\\", "\\\\?\\UNC\\")

[mikf]

@AlttiRi What's the exact path you are trying to use? I've tested with \\VBOXSVR\tmp\foobar and other paths longer than 255 characters before committing ac80474 and that worked as excepted.

[AlttiRi]

git-bash:

cd "//VBOXSVR/tmp" && gallery-dl https://twitter.com/SpaceX/status/1473671809870725121

[AlttiRi]

Yes, it's Git-Bash' issue since CMD does not support UNC paths as current directories.

[AlttiRi]

Looks fixed. (1.20.1-dev)