Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subscribestar] Bug: Accessing only the preview image is treated as success #4468

Closed
GiovanH opened this issue Aug 27, 2023 · 4 comments
Closed

Comments

@GiovanH
Copy link
Contributor

GiovanH commented Aug 27, 2023

There are several cases where, even if you've logged in successfully, Subscribestar will return the preview (blurred) URL for an image as if it were the full image, instead of throwing an authorization error. Because this saves preview images as the canonical image for the post, this silently prevents subsequent runs from updating posts with the missing images, which breaks rolling archives.

This can be easily detected by comparing preview_url to url.
Note that directly saving an individual post will throw an authorization error if you only have access to the previews, but posts gathered from a user feed do not.

Alternatively, preview urls could have a different output filename. This probably is not desired, as it results in saving both the preview and the main image.

@GiovanH GiovanH changed the title [Subscribestar] Only getting the preview image should count as an error [Subscribestar] Bug: Accessing only the preview image is treated as success Aug 27, 2023
@Hrxn
Copy link
Contributor

Hrxn commented Aug 28, 2023

This can be easily detected by comparing preview_url to url.

The implication is that this is already in the metadata extracted by gallery-dl?

@GiovanH
Copy link
Contributor Author

GiovanH commented Aug 28, 2023

This can be easily detected by comparing preview_url to url.

The implication is that this is already in the metadata extracted by gallery-dl?

Yes, preview_url is already available in the metadata exposed to gallery-dl.

Using it as I describe here probably isn't the best way to accomplish this (I haven't inspected the actual API body, just the metadata after gallery-dl processes it), but it would work if the status of the post really is opaque at the listing level.

@Hrxn
Copy link
Contributor

Hrxn commented Aug 28, 2023

And url is the correct URL that is non-blurred, full size etc. ?

@GiovanH
Copy link
Contributor Author

GiovanH commented Aug 28, 2023

If it's a post you have access to, preview_url is blurred and url is a (much longer) url to the full size resource.

If it's a post you don't have access to, url points to the same blurred image as preview_url

Again, weirdly, this doesn't happen if you try to fetch a specific post directly by url.

mikf added a commit that referenced this issue Sep 5, 2023
and show a warning message when posts contain previews
@mikf mikf added the site:bug label Oct 3, 2023
@mikf mikf closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants