Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redgifs] wrong value for userName when using collection extractor #4508

Closed
Hrxn opened this issue Sep 8, 2023 · 2 comments
Closed

[redgifs] wrong value for userName when using collection extractor #4508

Hrxn opened this issue Sep 8, 2023 · 2 comments

Comments

@Hrxn
Copy link
Contributor

Hrxn commented Sep 8, 2023

Uh, exactly what it says on the tin? 馃槃

For example, with a collection URL like this: https://www.redgifs.com/users/<testUser>/collections/<collection_id>

The value for userName is now testUser, instead of the real user name from the uploader..
If I take the single URL from the entry in a collection and run it with gallery-dl (i.e. ends up using the "image" extractor), the userName is correct again.

Latest gallery-dl master.

mikf added a commit that referenced this issue Sep 12, 2023
@mikf
Copy link
Owner

mikf commented Sep 15, 2023

I moved all collection metadatas into its own separate field (ae5e049).
userName is now the name of the uploader, and collection[userName] is the collection owner.

@mikf mikf closed this as completed Sep 15, 2023
@Hrxn
Copy link
Contributor Author

Hrxn commented Sep 16, 2023

Hey, I saw this commit basically as it happened and immediately grabbed the fresh sources to test it right away, so I could confirm and close my opened issues again as soon as possible, but unfortunately my laptop battery died, and something with the charger was also fishy and now I'm gonna need to replace both apparently..

I just realized this comes off a bit as my-dog-ate-the-homework, but it's actually true, I swear! 馃槅

Anyway, just tested this, can confirm it works perfectly now! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants