Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong path in exec finalize command #4633

Closed
Skyofflad opened this issue Oct 6, 2023 · 2 comments
Closed

Wrong path in exec finalize command #4633

Skyofflad opened this issue Oct 6, 2023 · 2 comments
Labels
bug enhancement

Comments

@Skyofflad
Copy link

In exec finalize event, command argument {} was replaced with the download folder path.
In 1.26.0 {} is replaced with the full path of the last file (checked or downloaded).
Is it supposed to be like this, or is this a bug?
@mikf
Copy link
Owner

mikf commented Oct 7, 2023

The changes from 0ef1fca are to blame.
Instead of restoring this functionality to how it was before, I'd rather add some more replacement fields like {filename}, {directory}, and {path}, I think.

mikf added a commit that referenced this issue Oct 9, 2023
@mikf
[pp:exec] support more replacement fields for '--exec' (#4633)
67ba4ee 
- {_directory}
- {_filename}
- {_path} (alias for {})
@mikf
Copy link
Owner

mikf commented Oct 9, 2023

With 67ba4ee, you can use {_directory} and it will always be the download folder path.

@mikf mikf closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikf @Skyofflad