Snap packaging improvements #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terfaces (mikf#197) * FIXME no longer applied * Obsoleted HOME environment variable assignment Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
The selective-pull stage snap is superseded by selective-checkout, prefer the new one. Refer-to: Selective-checkout: Check out the tagged release revision if it isn't promoted to the stable channel <https://forum.snapcraft.io/t/the-selective-pull-scriptlet-stage-snap-workaround/10389> Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Refer-to: Scriptlets <https://docs.snapcraft.io/scriptlets/4892> Refer-to: Tab completion for snaps <https://docs.snapcraft.io/tab-completion-for-snaps/2261> Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This patch ensures that the user will be acknowledge the missing connection to the `removable-media` interface. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
|
I'm aware of the breakage of the snap building due to commit 6612081 and is working on fixing it. |
Building the unnecessary list of supported sites failes because |
brlin-tw
added a commit
to brlin-tw/gallery-dl
that referenced
this pull request
Mar 29, 2019
The build failed due to missing `requests` build dependency, this patch drops the unused component to build to avoid the problem. The manpages are still built for the upcoming read-manual workaround. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
mikf
pushed a commit
that referenced
this pull request
Mar 29, 2019
The build failed due to missing `requests` build dependency, this patch drops the unused component to build to avoid the problem. The manpages are still built for the upcoming read-manual workaround. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.