Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize vxtwitter URLs #2621

Merged
merged 3 commits into from May 25, 2022
Merged

recognize vxtwitter URLs #2621

merged 3 commits into from May 25, 2022

Conversation

thatfuckingbird
Copy link
Contributor

Now that fxtwitter.com fell out of favor/shut down, people switched to posting vxtwitter.com links (works the same as fxtwitter did).
I realize this is not a very scalable solution, so if other such sites pop up we might need a better way than just having the regex match them all, but for now it's probably still good enough.

@mikf mikf merged commit da0696e into mikf:master May 25, 2022
@mikf
Copy link
Owner

mikf commented May 25, 2022

I realize this is not a very scalable solution, so if other such sites pop up we might need a better way than just having the regex match them all, but for now it's probably still good enough.

We could have the TwitterExtractor class inherit from BaseExtractor, which would allow adding additional Twitter "instances" and matching arbitrary domains via config settings, but I don't know if that would be enough either.

Ultimately there should be a way to modify the URL patterns for all sites through some config setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants