[kemonoparty] add 'favorites' option (#2826)

[enduser420]

No description provided.

[one-bad-duck]

I've tested this with Ubuntu 20.04 in WSL and it is working using the new setting. One thing though is that URL inputs specifying posts or artists will be ignored so the setting is the only way to choose. That's fine for me, but I thought I'd point it out. If this is fine, this pull could close #2826 maybe.

[enduser420]

I can make it recognize them, but should specifying them overwrite the config option? (is the config option useless?)

[mikf]

(is the config option useless?)

Kind of, but I would still keep it, now that you have implemented it.

but should specifying them overwrite the config option?

Yes, use type from the URL params if given, otherwise fall back to the config option.

---

To capture URL arguments, extend pattern to

    pattern = BASE_PATTERN + r"/favorites(?:/?\?([^#]+))?"

and use text.parse_query in the constructor

    def __init__(self, match):
        KemonopartyExtractor.__init__(self, match)
        self.favorites = text.parse_query(match.group(2)).get("type")

[one-bad-duck]

Thank you both very much. I tested it again using Coomer and Kemonoparty in Ubuntu 20.04 via WSL2. It works both ways and the URL does take priority over the option.

[mikf]

In a sense this is worse than before. because it always calls self.config() even if the URL query parameters have a type.

By using a or b, b only gets evaluated when a is empty and not at all when a has a "true" value.

[enduser420]

I see, thanks.