[twitter] restore the text of truncated retweets #3430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move code to a static method
move code to '_repair_retweet'
mikf
added a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text of retweets often gets truncated because Twitter prepends the original author's username to it:
(taken from here, warning: kind of NSFW)
This PR solves the issue by prepending the "prefix" to the text of the original tweet. I tried using
retweets=originalinstead, but that would change a lot of the other fields and break my existing archive database.The legacy pagination method needs more testing because the corresponding API endpoints never seemed to return any retweets for me.