Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[realbooru] Add Realbooru extractor #514

Merged
merged 1 commit into from Dec 16, 2019
Merged

[realbooru] Add Realbooru extractor #514

merged 1 commit into from Dec 16, 2019

Conversation

TheOddball
Copy link
Contributor

@TheOddball TheOddball commented Dec 13, 2019

Realbooru uses the same version of booru as gel, so I used that extractor with changed variables, works perfectly.

@mikf
Copy link
Owner

mikf commented Dec 13, 2019

Instead of copy-pasting and adjusting the entire Gelbooru code, you should do this with the code from safebooru.py (or rule34.py). Much less boilerplate.
(I'm also not the copyright holder for realbooru.py, by the way)

As for tests: Remove all the test result sections, so that everything looks like

    test = ("https://realbooru.com/…",)

and actually passes the CI. Or run python test/test_results realbooru locally and adjust the test results until it passes.

I should also mention that there will, at some point, be general extractors for everything …booru related (#234, #473) and this, among all other idividual …booru extractors, is most likely going to be deleted at that point.

@TheOddball
Copy link
Contributor Author

Well.. To be fair I'm not a Python programmer. I merely edited the gelbooru one to work, feel free to close this if it's not good enough

@mikf mikf merged commit 9a4ce20 into mikf:master Dec 16, 2019
@mikf
Copy link
Owner

mikf commented Dec 16, 2019

It is good enough, don't worry about it.

Instead of editing the Gelbooru file, you could have done so with the file for Safebooru and it would have been at lot less code. I've done that now myself and also "fixed" the tests I was talking about: 31a2983.

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants