Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload analytics into a web worker #41

Closed
MikhaD opened this issue Apr 16, 2022 · 4 comments
Closed

Offload analytics into a web worker #41

MikhaD opened this issue Apr 16, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@MikhaD
Copy link
Owner

MikhaD commented Apr 16, 2022

Description
Try using partytown to offload the Google analytics code into a web worker to see if there is any increase in performance.

Reasoning
The animations lag on mobile, leading me to believe there is performance to be gained.

@MikhaD MikhaD added the enhancement New feature or request label Apr 16, 2022
@MikhaD MikhaD added this to the 1.5 milestone Jun 16, 2022
@MikhaD
Copy link
Owner Author

MikhaD commented Jan 14, 2023

Turns out my animations were lagging in Firefox mobile even if analytics were removed. The lag is only on Firefox. Installing the PWA from Chrome eliminated the lag.
Taking this into consideration I think partytown is overkill.

@MikhaD MikhaD closed this as completed Jan 14, 2023
@lukeswitz
Copy link

Why are you using Google analytics in an open source project in the first place?

@MikhaD
Copy link
Owner Author

MikhaD commented Jan 14, 2023

Because I want to see how many people are using the thing I created. As per our previous conversation I have added an if statement to prevent analytics running if the domain is different, so that even identical clones of the repo will not run the analytics script.

@lukeswitz
Copy link

While I understand that it may not be illegal to include this service, I am personally uncomfortable with my data being tracked and collected by a third-party service without my explicit consent.

As a user, I believe that my privacy should be protected and that I should have the ability to opt-out of data collection if I so choose. I also believe that any data collection should be done with my informed consent, and that any data collected should be protected and not shared with any third parties without my permission.

I understand that you may have included Google Analytics in order to gain insights and improve the project, but I would kindly ask that you consider the privacy implications for your users and offer them the option to opt-out of data collection. I would also appreciate it if you could provide more transparency about how the data is being used, and how it's protected.

Thank you for your consideration.

Sincerely,

Luke Switzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants