#11 bug fix : gap between content and nav / fixing navbar/logout on mobile. #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11 Mobile Nav Padding Top bug fix
These changes will add a gap between the bottom of pages and the bottom nav bar as to not cut off content, as well as fixing the bottom nav bar breaking on mobile/tablet. It also changes some font sizing and issues with logout z-index.
Fixing nav bar icon
Context: The nav bar would break around 600px width and on really small viewports. This was due to a css rule from material ui creating a min-width on the buttons in the nav. I gave the navbar buttons all a rule overruling the MUI rule and this fixed the issue.
Before:
After:
Creating a gap between content and nav
Context: On mobile/tablets going to the bottom of the screen, the navbar would overlap content. I was able to fix this issue on the library of context, I just added a class to the tab container which holds all the media cards. I then added a margin-bottom rule to this class and made it responsive by using vh units thus there's no obscenely large gap on any viewports. I made a similar fix with the mentorship page, the container already had a class defined however so it was just adding a margin-bottom rule to it.
Before:
After:
Z-index fix for logout
Before:
After:
Font size fixes:
Context: The library of context tab picker had a very large font size that on some screens would not allow you to click the last tab. I changed the font to be responsive on mobile/tablet and this fixed the issue for the most part.
Before:
After: